Skip to content

Commit

Permalink
Update to Node v18 (#2112)
Browse files Browse the repository at this point in the history
  • Loading branch information
leSamo committed May 30, 2024
1 parent 7b6ff68 commit 70a74c7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ language: node_js
sudo: required
notifications:
email: false
dist: focal
node_js:
- '16'
- '18'
install:
- npm ci
jobs:
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
Red Hat Insights Vulnerability service is used to assess and monitor the status of security vulnerabilities on RHEL systems, understand the level of exposure of infrastructure, and plan a course of action. This is the front-end repository for this service.

## First time setup
1. Make sure you have [Node.js](https://nodejs.org/en/) version >= 16 installed
1. Make sure you have [Node.js](https://nodejs.org/en/) version >= 18 installed
2. Run [script to patch your `/etc/hosts`](https://github.com/RedHatInsights/insights-proxy/blob/master/scripts/patch-etc-hosts.sh)
3. Make sure you are using [Red Hat proxy](http://hdn.corp.redhat.com/proxy.pac)

Expand Down Expand Up @@ -58,10 +58,10 @@ Any push to the following branches will trigger a build in [vulnerability-ui-bui
## Internationalization

### Translation keys
Translation keys are saved in [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js).
Translation keys are saved in [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js).

### Generating translation keys
Each time you add a new translation keys you need to run `npm run translations`, which will automatically generate JSON files for every language into [`locales/`](https://github.com/RedHatInsights/vulnerability-ui/tree/master/locales) folder based on the entries in the [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js).
Each time you add a new translation keys you need to run `npm run translations`, which will automatically generate JSON files for every language into [`locales/`](https://github.com/RedHatInsights/vulnerability-ui/tree/master/locales) folder based on the entries in the [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js).

### Using translated strings
There are two ways to use translated strings:
Expand Down
2 changes: 1 addition & 1 deletion build_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export COMPONENT="vulnerability-ui"
export IMAGE="quay.io/cloudservices/vulnerability-ui"
export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace
export APP_ROOT=$(pwd)
export NODE_BUILD_VERSION=16
export NODE_BUILD_VERSION=18
COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master

set -exv
Expand Down
2 changes: 1 addition & 1 deletion pr_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export COMPONENT="vulnerability-ui"
export IMAGE="quay.io/cloudservices/vulnerability-ui"
export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace
export APP_ROOT=$(pwd)
export NODE_BUILD_VERSION=16
export NODE_BUILD_VERSION=18
COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master

# --------------------------------------------
Expand Down

0 comments on commit 70a74c7

Please sign in to comment.