refactor(RHINENG-5926) ZeroState checks for RHEL systems #2070
Conversation
|
Commits missing Jira IDs: |
adonispuente
force-pushed
the
zeroS
branch
2 times, most recently
from
0ecec39
to
833cc00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2070 +/- ##
==========================================
- Coverage 68.10% 67.84% -0.26%
==========================================
Files 131 131
Lines 3414 3418 +4
Branches 1064 1062 -2
==========================================
- Hits 2325 2319 -6
- Misses 1089 1099 +10 ☔ View full report in Codecov by Sentry. |
| let isEdgeParityEnabled = true; | ||
| let hasEdgeDevices = false; | ||
| let hasConventionalSystems = false; | ||
| expect(checkForAccountSystems(isEdgeParityEnabled, hasEdgeDevices, hasConventionalSystems)).toBe(false) |
There was a problem hiding this comment.
As we have migrated to RTL, would it be better to assert on the UI element itself instead of the checkForAccountSystems function result?
There was a problem hiding this comment.
Originally that was the plan, however the routing page is essentially just a fed module now. So we're really just making sure the right state renders when passing in the correct items
Updates zero state to consume children, and change the api request to check for RHEL systems as opposed to ALL systems