fix(RHINENG-10459): route SystemDetails page using InsightsElement #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referenced Jiras: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2119 +/- ##
==========================================
- Coverage 67.58% 66.65% -0.94%
==========================================
Files 131 128 -3
Lines 3437 3440 +3
Branches 1066 1068 +2
==========================================
- Hits 2323 2293 -30
- Misses 1114 1147 +33 ☔ View full report in Codecov by Sentry. |
Fewwy
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://issues.redhat.com/browse/RHINENG-10459 by routing to SytemsCVEs using InsightsElement. Before this, as the component was not wrapped with InsightsElement, account context, and also other insights element component logic (e.g zero-state check) were not enabled on it. Now, account state context properly passes the required info
includesCvesWithoutErratato SystemCVEs and thus the filter is fixed.