#51 Refactor score logic outside the Vue app #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skontar
approved these changes
Mar 12, 2024
jsvob
approved these changes
Mar 12, 2024
skontar
requested changes
Mar 12, 2024
There was a problem hiding this comment.
I think we should also change line 172 in index.html to force loading new app.js version and not the cached one on some browsers.
Good catch! done |
skontar
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I work with Chris Turner and our team would like to use your calculator scoring logic for V4 scoring.
In the PR you'll see I've moved the scoring logic outside of the Vue app methods section in order to make it more easily available for 3rd party use (when a full web application is not required). This works for us.
I've attempted to leave the structure of the Vue app the same with no build steps introduced and minimal refactoring.
I've done limited testing comparing several different vector selections to the production V4 calculator and am seeing matching scores and no error messages.