Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitoring emails for failed tasks in OSIDB #296

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fix monitoring emails for failed tasks in OSIDB #296

merged 2 commits into from
Aug 7, 2023

Conversation

Elkasitu
Copy link
Contributor

@Elkasitu Elkasitu commented Aug 7, 2023

This PR introduces two commits which will:

  • Actually save the task results in the database in stage & production
  • Ensure the pool workers are gevent and psycogreen patched

Adrian Torres added 2 commits August 7, 2023 13:46
Do not override CELERY_RESULT_BACKEND in stage/prod
3bf2b5d 
This was preventing django-celery-results from working properly in the
staging environment which is needed in order to send the failure emails.
Ensure stdlib and psycopg are patched for celery gevent mode
23a7cce
@Elkasitu Elkasitu added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label Aug 7, 2023
@Elkasitu Elkasitu requested review from juspence and a team August 7, 2023 12:39
@Elkasitu Elkasitu mentioned this pull request Aug 7, 2023
Closed
@Elkasitu
Copy link
Contributor Author

Elkasitu commented Aug 7, 2023

These changes are live and tested on stage (unless someone else pushes to master in the meantime)

juspence
juspence approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@juspence juspence left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I didn't catch this in the first PR and thank you for fixing! I also see TaskResults are being created in stage now. All of the failures so far are the same 500 Internal Server Error for the erratum with ID 9901.

@Elkasitu Elkasitu added this pull request to the merge queue Aug 7, 2023
Merged via the queue into master with commit d134895 Aug 7, 2023
12 checks passed
@Elkasitu Elkasitu deleted the email-fix branch August 7, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juspence juspence juspence approved these changes

Assignees
No one assigned
Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Elkasitu @juspence