Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rudimentary API request logging #592

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

jsvob
Copy link
Contributor

@jsvob jsvob commented Jun 20, 2024

Closes OSIDB-2514

@jsvob
Copy link
Contributor Author

jsvob commented Jun 20, 2024

No idea how to test logging without spending time on researching that, which I (we all) don't have. I think it's enough that all tests run fine and that it uses logging that's already well-used and tested by actual use.

@jsvob jsvob requested a review from a team June 21, 2024 13:17
osidb/api_views.py Outdated Show resolved Hide resolved
osidb/api_views.py Outdated Show resolved Hide resolved
@jsvob jsvob force-pushed the rudimentary_user_path_logging branch from f66d436 to ecab215 Compare June 24, 2024 12:04
@jsvob jsvob force-pushed the rudimentary_user_path_logging branch from ecab215 to 5b37540 Compare June 24, 2024 12:11
@jsvob jsvob requested a review from osoukup June 24, 2024 12:11
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@jsvob jsvob added this pull request to the merge queue Jun 24, 2024
Merged via the queue into master with commit f621805 Jun 24, 2024
11 checks passed
@jsvob jsvob deleted the rudimentary_user_path_logging branch June 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants