Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that 'repositories' variable in the 'repositories' role can be used as intended #196

Closed
robled opened this issue Dec 13, 2017 · 3 comments
Assignees

Comments

@robled
Copy link
Contributor

robled commented Dec 13, 2017

I received a report that this functionality did not work as intended, in that if the empty (by default) 'repositories' variable is overridden via Ansible group_vars, the 'repositories' role will skip over that input data, with no error produced via Ansible. I was able to reproduce this problem in preliminary testing. I'll test this again and provide more details on the scenario.

@robled robled assigned robled and greg-hellings and unassigned robled Dec 13, 2017
@robled
Copy link
Contributor Author

robled commented Dec 13, 2017

After further testing and discussion, it seems likely that variable precedence of group_vars included with cinch in the jenkins_slave role are overriding inputs given by users via the all group_vars file. Given that the use case here is highly likely that we want to append additional repos, we should resolve it in that way, which would mean extending the repositories role to allow for this.

@robled
Copy link
Contributor Author

robled commented Feb 1, 2018

@greg-hellings - was this resolved here?

#198

@greg-hellings
Copy link
Contributor

Let's just say "yes" and roll with it. I'm pretty sure this is what prompted that changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants