Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VM cleanup in VMware provider #114

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add support for VM cleanup in VMware provider #114

merged 1 commit into from
Nov 24, 2023

Conversation

Gauravtalreja1
Copy link
Contributor

cloudwash vmware

@Gauravtalreja1
Add support for VM cleanup in VMware provider
bfb6dd1 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
@Gauravtalreja1
Copy link
Contributor Author

cc: @jyejare @mshriver @omkarkhatavkar @ntkathole

jyejare
jyejare approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with non-blocking suggestion!

conf/vmware.yaml.template Show resolved Hide resolved
@jyejare jyejare merged commit 7bf451a into RedHatQE:master Nov 24, 2023
7 checks passed
@jyejare jyejare mentioned this pull request Nov 24, 2023
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the vmware-provider branch November 24, 2023 09:30
@Gauravtalreja1
Copy link
Contributor Author

Thank you @jyejare :)

@jyejare
Copy link
Collaborator

jyejare commented Nov 27, 2023

@Gauravtalreja1 Let me know if you need a new release for it immediately ?

@omkarkhatavkar omkarkhatavkar mentioned this pull request Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gauravtalreja1 @jyejare