Initial scaffolding #14
Conversation
quarckster
force-pushed
the
scaffolding
branch
from
195f46c
to
377fa3e
Compare
quarckster
force-pushed
the
scaffolding
branch
from
377fa3e
to
3c10251
Compare
|
Just used this branch to create a new repo, its great! Thanks @quarckster, you rock |
| zip_safe = False | ||
| include_package_data = True | ||
| packages = find: | ||
| entry_points = file:entry_points.txt |
There was a problem hiding this comment.
| entry_points = file:entry_points.txt | |
| entry_points = file:entry_points.txt | |
| install_requires = | |
| taretto | |
| importscan |
| import importscan | ||
|
|
||
| from pkg_resources import iter_entry_points | ||
| from taretto.modeling import EntityCollections |
There was a problem hiding this comment.
This import is breaking with the use of apipkg.initpkg, as this modifies the namespace and results in only taretto.ui and taretto.navigate resolving when taretto is installed as a dependency.
I played with adding modeling to the exported namespace, but class imports from the module failed.
❯ git diff
diff --git a/src/taretto/__init__.py b/src/taretto/__init__.py
index b39d42a..4aa38c9 100644
--- a/src/taretto/__init__.py
+++ b/src/taretto/__init__.py
@@ -2,6 +2,7 @@ from apipkg import initpkg as __initpkg
# fmt: off
__initpkg(__name__, {
+ "modeling": "taretto.modeling",
"navigate": "navmazing",
"ui": {
"core": "widgetastic.widget", # todo: html widget library here, limit to base
❯ pip freeze |grep taretto
-e git+ssh://git@github.com/mshriver/taretto.git@3c102517377b4f994fbb3fe421de5ea3cbf6dd7f#egg=taretto
❯ ipython
Python 3.8.12 (default, Aug 30 2021, 00:00:00)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.0.1 -- An enhanced Interactive Python. Type '?' for help.
In [1]: from taretto import modeling
In [2]: from taretto.modeling import EntityCollections
Fatal Python error: Cannot recover from stack overflow.
Python runtime state: initialized
Thread 0x00007fe5cba00640 (most recent call first):
File "/usr/lib64/python3.8/threading.py", line 302 in wait
File "/usr/lib64/python3.8/threading.py", line 558 in wait
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/IPython/core/history.py", line 829 in run
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/IPython/core/history.py", line 60 in only_when_enabled
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/decorator.py", line 232 in fun
File "/usr/lib64/python3.8/threading.py", line 932 in _bootstrap_inner
File "/usr/lib64/python3.8/threading.py", line 890 in _bootstrap
Current thread 0x00007fe5dad43740 (most recent call first):
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/apipkg/__init__.py", line 148 in importobj
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/apipkg/__init__.py", line 290 in getmod
File "/home/mshriver/repos/satqe/robottelo/.robottelo/lib64/python3.8/site-packages/apipkg/__init__.py", line 305 in __getattribute__
<loop on above 3 lines>
...
[1] 324960 IOT instruction (core dumped) ipython
|
|
||
|
|
||
| @attr.s | ||
| class BaseEntity(object): |
There was a problem hiding this comment.
I'm not seeing the connection to sentaku.Element, even though taretto.context.Element, am I missing something or is that not part of this PR?
The cookie cutter application has implementation contexts, but no sentaku.Element classes that can have contextual methods/properties without inheriting both BaseEntity and taretto.context.Element?
| @@ -0,0 +1,66 @@ | |||
| """Project path helpers | |||
There was a problem hiding this comment.
based on what this file does, i would prefer we never add it
| from collections import Callable | ||
|
|
||
| import attr | ||
| from cached_property import cached_property |
There was a problem hiding this comment.
use the stdlib one
| def filter(self, filter): | ||
| filters = self.filters.copy() | ||
| filters.update(filter) | ||
| return attr.evolve(self, filters=filters) |
There was a problem hiding this comment.
i suspect having a random dict as filters will set us up for pain
i'd like to see filters separated from collections to avoid the down payments that will eventually come from bringing them too close together
|
|
||
|
|
||
| @attr.s | ||
| class CollectionProperty(object): |
There was a problem hiding this comment.
starting to get the impression, this ought to land in sentaku, not taretto
| [{{cookiecutter.application_name}}.application_collections] | ||
|
|
||
| [pytest11] | ||
| {{cookiecutter.application_name}} = {{cookiecutter.application_name}}.pytest_plugin |
There was a problem hiding this comment.
pytest plugin all the things is not a good pattern per se, shouldn't be the default
| return cls.for_entity(obj, *k, **kw).filter(filt) | ||
|
|
||
| def instantiate(self, *args, **kwargs): | ||
| return self.ENTITY.from_collection(self, *args, **kwargs) |
There was a problem hiding this comment.
it may also be nice to create an alias to instantiate with __call__ this would make it so people can "instantiate" from the collection
| from {{cookiecutter.application_name}}.base.application.implementations.web_ui import ViaWebUI | ||
|
|
||
|
|
||
| class Application(object): |
There was a problem hiding this comment.
not specific to this pr, but is there a reason why we're hanging on to py2 support?
tarettocli tool:taretto application create --path some_path