[1LP][RFR] Firefox 60+ fix #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
reviewed
Aug 22, 2018
src/widgetastic/browser.py
Outdated
| @@ -811,14 +816,12 @@ def __eq__(self, other): | |||
| return self._o == other._o and self._browser == other._browser | |||
|
|
|||
| def elements( | |||
| self, locator, parent=None, check_visibility=False, check_safe=True, | |||
| force_check_safe=False): | |||
| self, locator, parent=None, check_visibility=False, check_safe=True): | |||
There was a problem hiding this comment.
Not seeing any direct use of this kwarg in wt.patternfly or integration_tests so I think its clean to remove.
There was a problem hiding this comment.
I checked this before removal.
|
I caught two more issues to sort out. |
|
all these changes passed local testing against most troublesome tests like ansible automation and etc using FF61.0.2 + geckodriver 0.20.1 + selenium 3.12. |
|
Two travis test failures, please investigate |
|
those two tests expect to get reply too quickly. retry option adds some delay |
izapolsk
force-pushed
the
ff60_fix
branch
3 times, most recently
from
67cb610
to
bfa8ce5
Compare
izapolsk
force-pushed
the
ff60_fix
branch
15 times, most recently
from
e35c7e7
to
f4ca9a1
Compare
izapolsk
force-pushed
the
ff60_fix
branch
14 times, most recently
from
9d55628
to
1d09b62
Compare
src/widgetastic/utils.py
Outdated
| from cached_property import cached_property | ||
| from functools import wraps |
There was a problem hiding this comment.
REQUIRED use six.wraps to get the correct metadata setup on python2
mshriver
reviewed
Aug 30, 2018
izapolsk
commented
Aug 30, 2018
src/widgetastic/browser.py
Outdated
| def elements( | ||
| self, locator, parent=None, check_visibility=False, check_safe=True, | ||
| force_check_safe=False): | ||
| self, locator, parent=None, check_visibility=False, check_safe=True): |
There was a problem hiding this comment.
REQUIRED: restore option and add deprecation warning
quarckster
approved these changes
Aug 31, 2018
mshriver
reviewed
Sep 17, 2018
mshriver
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two nav issues in Firefox 60+ and CloudForms 5.10.
As a result, it tries to access element when page isn't ready yet.
I'm going to remove that check. The other way is to add force_check_safe in all places where it is necessary.
this Pr intends to fix both issues.