[RFR] fixing widgets in rowspan table #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
force-pushed
the
fix_rowspan_table_widgets
branch
from
eb11f1f
to
699aad2
Compare
izapolsk
changed the title
izapolsk
force-pushed
the
fix_rowspan_table_widgets
branch
from
699aad2
to
da08b99
Compare
|
@izapolsk confirm our tests are also passing with this fix tests output - > SatelliteQE/airgun#299 (comment) |
|
@izapolsk many thanks |
mshriver
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quickfix for issue related to usage of widgets in rows with row/colspan.
There will be PR with full refactor of Table object soon.
FIXES #143