Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log noise with read() #162

Merged
merged 1 commit into from Oct 2, 2019
Merged

Reduce log noise with read() #162

merged 1 commit into from Oct 2, 2019

Conversation

mfalesni
Copy link
Contributor

@mfalesni mfalesni commented Oct 1, 2019

  • Change default NotImplementedError in read() for DoNotReadThisWidget
  • Turn up the notification about not reading the widget in logs from INFO to WARNING

@mfalesni
Reduce log noise with read()
d7bd1f0 
* Change default NotImplementedError in read() for DoNotReadThisWidget
* Turn up the notification about not reading the widget in logs from INFO to WARNING
@izapolsk
Copy link
Contributor

izapolsk commented Oct 2, 2019

@mfalesni, what do you want DoNotReadThisWidget for ?

@mfalesni
Copy link
Contributor Author

mfalesni commented Oct 2, 2019

@izapolsk I get a ton of errors from reading views containing Button widgets and such. If the widget does not have support for reading, I want to have it more graceful with just a warning that that is happening.

@psav psav merged commit fc4f95b into RedHatQE:master Oct 2, 2019
@mfalesni mfalesni deleted the reading-noise branch October 2, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarckster quarckster quarckster approved these changes

@izapolsk izapolsk izapolsk approved these changes

@mshriver mshriver mshriver approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mfalesni @izapolsk @quarckster @mshriver @psav