-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jsmin dependency #204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 86.63% 86.53% -0.10%
==========================================
Files 18 18
Lines 2551 2547 -4
==========================================
- Hits 2210 2204 -6
- Misses 341 343 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with removing jsmin dependency - thanks for cleaning that up!
There is a logical change here too with handling of kwargs
in execute_script
that I have some concern about.
I'll split those 2 changes and send a additional pr |
@RonnyPfannschmidt fine with it being in the same PR, just want to make sure unit tests are covering the call stack testing the execution of the script. |
Small rebase and I'm happy to merge @RonnyPfannschmidt |
6b2e038
to
0adae65
Compare
0adae65
to
6a52d41
Compare
jsmin is a unmaintained since a while and breaks the build
im under the impression we practically only use it to remove some white-space from js code to send to selenium, so we should be fine without it