Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jsmin dependency #204

Merged
merged 3 commits into from
Sep 13, 2021
Merged

remove jsmin dependency #204

merged 3 commits into from
Sep 13, 2021

Conversation

RonnyPfannschmidt
Copy link
Collaborator

jsmin is a unmaintained since a while and breaks the build

im under the impression we practically only use it to remove some white-space from js code to send to selenium, so we should be fine without it

@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as ready for review September 8, 2021 09:03
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #204 (31b2b70) into master (839a81a) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 31b2b70 differs from pull request most recent head 6a52d41. Consider uploading reports for the commit 6a52d41 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   86.63%   86.53%   -0.10%     
==========================================
  Files          18       18              
  Lines        2551     2547       -4     
==========================================
- Hits         2210     2204       -6     
- Misses        341      343       +2     
Flag Coverage Δ
unittests 86.53% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/widgetastic/widget/input.py 96.61% <ø> (-0.06%) ⬇️
src/widgetastic/widget/table.py 89.16% <ø> (-0.17%) ⬇️
src/widgetastic/browser.py 75.90% <100.00%> (-0.24%) ⬇️
src/widgetastic/widget/select.py 91.97% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839a81a...6a52d41. Read the comment docs.

@quarckster
Copy link
Contributor

LGTM

@rsnyman
Copy link
Collaborator

rsnyman commented Sep 8, 2021

LGTM

Copy link
Collaborator

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with removing jsmin dependency - thanks for cleaning that up!

There is a logical change here too with handling of kwargs in execute_script that I have some concern about.

@RonnyPfannschmidt
Copy link
Collaborator Author

I'll split those 2 changes and send a additional pr

@mshriver
Copy link
Collaborator

mshriver commented Sep 8, 2021

@RonnyPfannschmidt fine with it being in the same PR, just want to make sure unit tests are covering the call stack testing the execution of the script.

@mshriver
Copy link
Collaborator

mshriver commented Sep 9, 2021

Small rebase and I'm happy to merge @RonnyPfannschmidt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants