Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum version to py38 #214

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

mshriver
Copy link
Collaborator

@mshriver mshriver commented Feb 16, 2022

Update pre-commit hooks, adjust github workflow matrix

RedHatQE/widgetastic.patternfly4#129

RedHatQE/widgetastic.patternfly#133

Update pre-commit hooks, adjust github workflow matrix
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #214 (8c51982) into master (7b22887) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 8c51982 differs from pull request most recent head ac92272. Consider uploading reports for the commit ac92272 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   86.58%   86.42%   -0.17%     
==========================================
  Files          18       18              
  Lines        2557     2556       -1     
==========================================
- Hits         2214     2209       -5     
- Misses        343      347       +4     
Flag Coverage Δ
unittests 86.42% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/widgetastic/utils.py 84.61% <100.00%> (ø)
src/widgetastic/widget/table.py 88.85% <0.00%> (-0.46%) ⬇️
src/widgetastic/browser.py 75.84% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b22887...ac92272. Read the comment docs.

@quarckster
Copy link
Contributor

LGTM

Copy link
Member

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mshriver mshriver force-pushed the set-py38 branch 3 times, most recently from 7a123b8 to ac92272 Compare February 25, 2022 01:45
@mshriver mshriver requested a review from quarckster April 1, 2022 13:39
@quarckster quarckster merged commit 13385b6 into RedHatQE:master Apr 4, 2022
quarckster pushed a commit to quarckster/widgetastic.core that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants