Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes method to get attributes for element #237

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

digitronik
Copy link
Member

No description provided.

@digitronik digitronik requested a review from mshriver June 26, 2023 15:10
@digitronik
Copy link
Member Author

CI will pass after #236

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #237 (5660636) into master (ff2c223) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 5660636 differs from pull request most recent head 2577847. Consider uploading reports for the commit 2577847 to get more accurate results

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   86.42%   86.45%   +0.03%     
==========================================
  Files          18       18              
  Lines        2564     2570       +6     
==========================================
+ Hits         2216     2222       +6     
  Misses        348      348              
Flag Coverage Δ
unittests 86.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/widgetastic/browser.py 75.51% <100.00%> (+0.27%) ⬆️

Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@LightOfHeaven1994 LightOfHeaven1994 merged commit c65c167 into RedHatQE:master Jun 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants