Initial work on dynamic table row addition #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfalesni
commented
May 22, 2017
src/widgetastic/widget.py
Outdated
| def row_count(self): | ||
| return len(self) | ||
|
|
||
| def add_row_handler(self): |
There was a problem hiding this comment.
This will handle adding new rows. Will be overridden by the specific implementation.
I haven't figured out yet the best way to handle deleting rows as a part of filling
mshriver
reviewed
May 22, 2017
| @@ -1313,6 +1325,12 @@ def assoc_column_position(self): | |||
| def __getitem__(self, at_index): | |||
| if not isinstance(at_index, int): | |||
| raise TypeError('table indexing only accepts integers') | |||
| if at_index < 0: | |||
There was a problem hiding this comment.
I think negative index use needs some comments/description
There was a problem hiding this comment.
Yep, I will add a comment around the handling.
mfalesni
force-pushed
the
table-fill-dynamic
branch
from
93aa830
to
f61d260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the tables that have the + at the bottom which adds a new row.