Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Subject> : no more than 20 words #72

Closed
ArthurMynl opened this issue Sep 13, 2022 · 4 comments
Closed

<Subject> : no more than 20 words #72

ArthurMynl opened this issue Sep 13, 2022 · 4 comments

Comments

@ArthurMynl
Copy link
Contributor

when creating a commit, the wizard says :
: no more than 20 words

But in reality, it's no more than 20 characters.

Should just change the wizard spelling

@RedJue
Copy link
Owner

RedJue commented Sep 19, 2022

when creating a commit, the wizard says : : no more than 20 words

But in reality, it's no more than 20 characters.

Should just change the wizard spelling
What did you spell?

@ArthurMynl
Copy link
Contributor Author

Capture d’écran 2022-09-19 à 11 16 13

for example here, my text is 21 characters, and so it can't be validated whether it's not more than 20 words, but more than 20 characters

@RedJue
Copy link
Owner

RedJue commented Sep 20, 2022

Capture d’écran 2022-09-19 à 11 16 13

for example here, my text is 21 characters, and so it can't be validated whether it's not more than 20 words, but more than 20 characters

You're right! it's my mistake, in code it's no more than 21 characters, to fixed it, you can follow here, set GitCommitPlugin.MaxSubjectWords limit as you like.

@ArthurMynl
Copy link
Contributor Author

I have corrected the bug and created a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants