Add compose extensions for android export #124

kaiwidmer · 2021-10-22T08:42:45Z

This pull request adds:

Icons: JetPack compose extension classes
Colors: Jetpack compose extension classes
Typography: Jetpack compose extension classes and letterspacing attribute for xml's
Config: additional fields to configure compose extension export

subdan · 2021-10-22T16:35:09Z

Thanks for the PR. I will review it on weekend.

subdan

Add Android JetPack Compose example project configured with FigmaExport.
Add information about this feature to README.md

subdan · 2021-10-26T14:40:40Z

README.md

+fun Colors.backgroundPrimary(): Color = colorResource(id = R.color.background_primary)
+```
+
+Icons will be exported to `drawable` directory as vector xml files. For `jetpack compose`, following code will be generated, if conifgured:


Suggested change

Icons will be exported to `drawable` directory as vector xml files. For `jetpack compose`, following code will be generated, if conifgured:

Icons will be exported to `drawable` directory as vector xml files. For Jetpack Compose, following code will be generated, if configured:

subdan · 2021-10-26T14:40:48Z

README.md

@@ -201,13 +201,61 @@ Example of these files:
 ### Android

 Colors will be exported to `values/colors.xml` and `values-night/colors.xml` files.
+For `jetpack compose`, following code will be generated, if conifgured:


Suggested change

For `jetpack compose`, following code will be generated, if conifgured:

For Jetpack Compose, following code will be generated, if configured:

subdan · 2021-10-26T14:41:01Z

README.md


 Vector images will be exported to `drawable` and `drawable-night` directories as vector `xml` files.
 Raster images will be exported to `drawable-???dpi` and `drawable-night-???dpi` directories as `png` or `webp` files.

-Typography will be exported to `values/typography.xml`
+Typography will be exported to `values/typography.xml`. For `jetpack compose`, following code will be generated, if conifgured:


Suggested change

Typography will be exported to `values/typography.xml`. For `jetpack compose`, following code will be generated, if conifgured:

Typography will be exported to `values/typography.xml`. For Jetpack Compose, following code will be generated, if configured:

subdan · 2021-10-26T14:42:21Z

README.md

@@ -312,6 +362,11 @@ android {
 }
 ```

+#### Compose


Suggested change

#### Compose

#### Jetpack Compose

subdan · 2021-10-26T14:42:33Z

README.md

@@ -14,7 +14,7 @@ Command line utility to export colors, typography, icons and images from Figma t
 * icon — Figma's component with small black/colorized vector image
 * image — Figma's components with colorized image (Light/Dark)

-The utility supports Dark Mode and SwiftUI.
+The utility supports Dark Mode, SwiftUI and Compose.


Suggested change

The utility supports Dark Mode, SwiftUI and Compose.

The utility supports Dark Mode, SwiftUI and Jetpack Compose.

subdan · 2021-10-26T14:42:45Z

Examples/README.md

@@ -39,3 +39,14 @@ There is an example Android Studio project in `AndroidExample` directory which d
 * To export icons run: `figma-export icons`
 * To export images run: `figma-export images`
 * To export typography run: `figma-export typography`
+
+### Example Android Compose project


Suggested change

### Example Android Compose project

### Example Android Jetpack Compose project

subdan · 2021-10-26T14:43:04Z

Examples/README.md

+
+### Example Android Compose project
+
+There is an example Android Studio project in `AndroidComposeExample` directory which demostrates how to use `figma-export` configured for compose.


Suggested change

There is an example Android Studio project in `AndroidComposeExample` directory which demostrates how to use `figma-export` configured for compose.

There is an example Android Studio project in `AndroidComposeExample` directory which demostrates how to use `figma-export` configured for Jetpack Compose.

subdan · 2021-10-26T14:44:50Z

README.md

@@ -278,6 +326,8 @@ Run `fastlane sync_colors` to run FigmaExport.

 In the `figma-export.yaml` file you must specify the following properties:
 - `android.mainRes`
+- `android.resourcePackage`
+- `android.mainSrc` if you want generate compose code


Suggested change

- `android.mainSrc` if you want generate compose code

- `android.mainSrc` if you want generate Jetpack Compose code

subdan · 2021-10-26T14:45:30Z

README.md

@@ -278,6 +326,8 @@ Run `fastlane sync_colors` to run FigmaExport.

 In the `figma-export.yaml` file you must specify the following properties:
 - `android.mainRes`
+- `android.resourcePackage`


Add information about this property.

subdan · 2021-10-26T14:46:08Z

README.md

@@ -312,6 +362,11 @@ android {
 }
 ```

+#### Compose
+For Typography, Colors and Icons you can enable code generation for the use with compose in your [config file](CONFIG.md):


Suggested change

For Typography, Colors and Icons you can enable code generation for the use with compose in your [config file](CONFIG.md):

For Typography, Colors and Icons you can enable code generation for the use with Jetpack Compose in your [config file](CONFIG.md):

subdan

Fix backward compatibility. resourcePackage property must be optional.

Add compose extensions for android export

2bd7347

subdan requested changes Oct 24, 2021

View reviewed changes

kaiwidmer added 2 commits October 26, 2021 13:44

Use unspecified tint color for icons per default

b9b6754

Provide example project and update readme

53e52fc

kaiwidmer requested a review from subdan October 26, 2021 11:47

subdan reviewed Oct 26, 2021

View reviewed changes

subdan requested changes Oct 26, 2021

View reviewed changes

kaiwidmer added 2 commits October 26, 2021 23:19

Fix readme

175d0b4

Make resourcePackage optional to fix backward compatibility

2a433d6

kaiwidmer requested a review from subdan October 26, 2021 21:33

subdan approved these changes Oct 27, 2021

View reviewed changes

subdan merged commit fe6dff8 into RedMadRobot:master Oct 27, 2021

kaiwidmer deleted the feature/android_export_extension branch October 27, 2021 08:25

subdan mentioned this pull request Nov 4, 2021

Android: Add color and typography export support to Jetpack Compose * .kt files #119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compose extensions for android export #124

Add compose extensions for android export #124

kaiwidmer commented Oct 22, 2021

subdan commented Oct 22, 2021

subdan left a comment •

edited

Loading

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan Oct 26, 2021

subdan left a comment

	Icons will be exported to `drawable` directory as vector xml files. For `jetpack compose`, following code will be generated, if conifgured:
	Icons will be exported to `drawable` directory as vector xml files. For Jetpack Compose, following code will be generated, if configured:

	For `jetpack compose`, following code will be generated, if conifgured:
	For Jetpack Compose, following code will be generated, if configured:

	Typography will be exported to `values/typography.xml`. For `jetpack compose`, following code will be generated, if conifgured:
	Typography will be exported to `values/typography.xml`. For Jetpack Compose, following code will be generated, if configured:

	The utility supports Dark Mode, SwiftUI and Compose.
	The utility supports Dark Mode, SwiftUI and Jetpack Compose.

	### Example Android Compose project
	### Example Android Jetpack Compose project


		### Example Android Compose project

		There is an example Android Studio project in `AndroidComposeExample` directory which demostrates how to use `figma-export` configured for compose.

	- `android.mainSrc` if you want generate compose code
	- `android.mainSrc` if you want generate Jetpack Compose code

	For Typography, Colors and Icons you can enable code generation for the use with compose in your [config file](CONFIG.md):
	For Typography, Colors and Icons you can enable code generation for the use with Jetpack Compose in your [config file](CONFIG.md):

Add compose extensions for android export #124

Add compose extensions for android export #124

Conversation

kaiwidmer commented Oct 22, 2021

subdan commented Oct 22, 2021

subdan left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

subdan left a comment

Choose a reason for hiding this comment

subdan left a comment •

edited

Loading