-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support high contrast colors #157
Conversation
add lightHighContrastFileId and darkHighContrastFileId add lightHCModeSuffix and darkHCModeSuffix
and the AssetPair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add information about supporting high contrast colors in the Design requirements and Features section.
- Add unit tests
dark palette → dark high contrast palette ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix typo
hight
→high
- Fix issue I point in the comment about dark appearance.
- Add unit tests for
XcodeColorExporter
which checks exporting high contrast colors foruseSingleFile
istrue
andfalse
. - I tried to run FigmaExport for Example project and it fails to export with the following error:
Bad asset name...
. You must fix this issue.
1 - Fix typo hight → high ✅ |
let darkHCSet: Set<AssetType> = foundDuplicate(assets: darkHC, errors: &errors) | ||
// AssetNotFoundInLightPalette | ||
checkSubtracting(firstAsset: lightSet, secondAsset: darkSet, errors: &errors) | ||
checkSubtracting(firstAsset: lightSet, secondAsset: lightHCSet, errors: &errors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method checkSubtracting
can generate darkAssetsNotFoundInLightPalette
error only but you specified light and light high contrast colors.
Thanks for the PR, @alexey1312! I've published a new version of FigmaExport with this feature. |
Thanks for the code review, @subdan ! 🙏 |
Solution for this issue