Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid argument 'required' in the ReferenceColumn __init__ function #1

Closed
sdelcourt opened this issue Sep 25, 2012 · 4 comments
Closed
Labels

Comments

@sdelcourt
Copy link
Contributor

Hi,

When trying to use the ReferenceColumn in a datagridfield, i have the following error:

TypeError: init() got an unexpected keyword argument 'required'

It comes from the line 22 of the file collective.datagridcolumns / collective / datagridcolumns / ReferenceColumn.py where it tries to init DataGriedField Column. The invalid argument is the 'required' parameter.
I checked the source of Column.py (https://github.com/collective/Products.DataGridField/blob/master/Products/DataGridField/Column.py) . It does not take any 'required' argument and the file has been unchanged for 3 years.

Is it a bug or am I missing the point of this new way to call the DataGridField Column init.?

Regards

S. Delcourt

@keul
Copy link
Contributor

keul commented Sep 25, 2012

Because we are dumb! ;-)

We added the "required" feature on the Column class in a custom branch of DataGridField (see https://github.com/RedTurtle/Products.DataGridField/blob/1.6/Products/DataGridField/Column.py#L25)

We'll need to fix this

@sdelcourt
Copy link
Contributor Author

Oh right. Thanks for the explanation ;).

@keul
Copy link
Contributor

keul commented Oct 17, 2012

Fixed in version 0.3.2

@keul keul closed this as completed Oct 17, 2012
keul added a commit that referenced this issue Oct 17, 2012
@sdelcourt
Copy link
Contributor Author

thanks for the fix! It spared me a monkey patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants