Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break validation for view with no specific context. #6

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Don't break validation for view with no specific context. #6

merged 2 commits into from
Jan 10, 2018

Conversation

bsuttor
Copy link
Contributor

@bsuttor bsuttor commented Jan 5, 2018

Sometimes, context is a view and has no portal_type

@coveralls
Copy link

coveralls commented Jan 5, 2018

Coverage Status

Coverage increased (+0.002%) to 40.714% when pulling bdd878e on IMIO:master into 8e6beff on RedTurtle:master.

@cekk
Copy link
Member

cekk commented Jan 8, 2018

@bsuttor I don't know why the coverage script for 4.3 breaks the build.
Seems not properly configured because it tries to check the coverage of all dependencies, not only this package.
Could you please try to disable it in .travis.yml and commit?
I don't really care about it

@bsuttor bsuttor changed the title Don't break validation for view with no spcific context. Don't break validation for view with no specific context. Jan 9, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.714% when pulling b68e299 on IMIO:master into 8e6beff on RedTurtle:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.714% when pulling c940df5 on IMIO:master into 8e6beff on RedTurtle:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.714% when pulling fa52ef5 on IMIO:master into 8e6beff on RedTurtle:master.

@bsuttor
Copy link
Contributor Author

bsuttor commented Jan 10, 2018

@cekk
I tried to properly configure coverage for Plone 4 and Plone 5 (with .coveragerc file), but I'm not able to get it works.
So I just comment Plone 4 travis tests, as you asked.

@cekk cekk merged commit 76380a5 into RedTurtle:master Jan 10, 2018
@cekk
Copy link
Member

cekk commented Jan 10, 2018

:(
Ok, i can try to fix it later.

coveralls isn't really important for me.

btw thanks for this pr!

@bsuttor
Copy link
Contributor Author

bsuttor commented Jan 15, 2018

It seems using

bin/coverage run bin/test
instead of
bin/createcoverage run bin/test

should fix travis coverage error ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants