return error for ft.alter w/o schema (#1754)

* return error for ft.alter w/o schema * Add test
RediSearch · Dec 28, 2020 · 97f9d94 · 97f9d94
1 parent 5f7f105
commit 97f9d94
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/module.c b/src/module.c
@@ -582,6 +582,8 @@ static int AlterIndexInternalCommand(RedisModuleCtx *ctx, RedisModuleString **ar
       }
     }
     IndexSpec_AddFields(sp, ctx, &ac, initialScan, &status);
+  } else {
+      return RedisModule_ReplyWithError(ctx, "ALTER must be followed by SCHEMA");
   }
 
   if (QueryError_HasError(&status)) {

diff --git a/tests/pytests/test.py b/tests/pytests/test.py
@@ -1896,6 +1896,8 @@ def testAlterIndex(env):
     env.expect('FT.ALTER', 'idx', 'SCHEMA', 'NOT_ADD', 'f2', 'TEXT').error()
     env.expect('FT.ALTER', 'idx', 'SCHEMA', 'ADD').error()
     env.expect('FT.ALTER', 'idx', 'SCHEMA', 'ADD', 'f2').error()
+    env.expect('FT.ALTER', 'idx', 'ADD', 'SCHEMA', 'f2', 'TEXT').error()
+    env.expect('FT.ALTER', 'idx', 'f2', 'TEXT').error()
 
 def testAlterValidation(env):
     # Test that constraints for ALTER comand