Issue993 FT.DEL redismodule_replicate

src/module.c

@@ -472,7 +472,7 @@ GEN_CONCURRENT_WRAPPER(CursorCommand, argc >= 4, AggregateCommand_ExecCursor,
 GEN_CONCURRENT_WRAPPER(AggregateCommand, argc >= 3, AggregateCommand_ExecAggregate,
                        CONCURRENT_POOL_SEARCH);
 
-/* FT.DEL {index} {doc_id}
+/* FT.DEL {index} {doc_id} [DD]
  *  Delete a document from the index. Returns 1 if the document was in the index, or 0 if not.
  *
  *  **NOTE**: This does not actually delete the document from the index, just marks it as deleted
@@ -525,7 +525,11 @@ int DeleteCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
       GCContext_OnDelete(sp->gc);
     }
   }
-  RedisModule_Replicate(ctx, "cv", RS_DEL_CMD, "cs", sp->name, argv[2]);
+  if (argc == 3) {
+    RedisModule_Replicate(ctx, RS_DEL_CMD, "cs", sp->name, argv[2]);
+  } else {
+    RedisModule_Replicate(ctx, RS_DEL_CMD, "csc", sp->name, argv[2], "dd");
+  }
   return RedisModule_ReplyWithLongLong(ctx, rc);
 }
 

src/pytest/test_replicate.py

@@ -0,0 +1,41 @@
+import subprocess
+import os
+import os.path
+from RLTest import Env
+import time
+
+def testDelReplicate():
+  env = Env(useSlaves=True)
+  master = env.getConnection()
+  slave = env.getSlaveConnection()  
+  env.assertContains("PONG", master.execute_command("ping"))
+  env.assertContains("PONG", slave.execute_command("ping"))  
+
+  env.assertOk(master.execute_command('ft.create', 'idx', 'schema', 'f', 'text'))
+
+  for i in range(10):
+    master.execute_command('ft.add', 'idx', 'doc%d' % i, 1.0, 'fields',
+                                      'f', 'hello world')
+
+  time.sleep(5)
+
+  for i in range(10):
+    # checking for insertion
+    env.assertEqual(['f', 'hello world'], 
+      master.execute_command('ft.get', 'idx', 'doc%d' % i))
+    env.assertEqual(['f', 'hello world'], 
+      slave.execute_command('ft.get', 'idx', 'doc%d' % i))
+
+    # deleting
+    env.assertEqual(1, master.execute_command(
+          'ft.del', 'idx', 'doc%d' % i, 'DD'))
+
+  time.sleep(5)
+
+  for i in range(10):
+    # checking for deletion
+    env.assertEqual(None, 
+      master.execute_command('ft.get', 'idx', 'doc%d' % i))
+    env.assertEqual(None, 
+      slave.execute_command('ft.get', 'idx', 'doc%d' % i))
+