Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

see MOD-507, fix crash happened on high light where document is not e… #1131

Merged
merged 1 commit into from
Mar 19, 2020
Merged

see MOD-507, fix crash happened on high light where document is not e… #1131

merged 1 commit into from
Mar 19, 2020

Conversation

MeirShpilraien
Copy link
Collaborator

…xist

mnunberg
mnunberg approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@mnunberg mnunberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ideally" the if (r->fields) would be in a different block, but this is 1.4 and is a quicker, more surgical fix.

@MeirShpilraien MeirShpilraien merged commit 28223e0 into 1.4 Mar 19, 2020
@MeirShpilraien MeirShpilraien deleted the fix_MOD-507 branch March 19, 2020 12:44
@emmanuelkeller emmanuelkeller added this to the 1.4.27 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnunberg mnunberg mnunberg approved these changes

Assignees
No one assigned
Labels
c:bug
Projects
None yet
Milestone
1.4.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MeirShpilraien @mnunberg @emmanuelkeller