Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ForkGC threshold to 100 #1255

Merged
merged 2 commits into from Jun 8, 2020
Merged

Change ForkGC threshold to 100 #1255

merged 2 commits into from Jun 8, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jun 8, 2020

fix #1252

@codecov
Copy link

codecov bot commented Jun 8, 2020 •
edited

Codecov Report

Merging #1255 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   83.62%   83.59%   -0.04%     
==========================================
  Files         142      142              
  Lines       19306    19306              
==========================================
- Hits        16145    16138       -7     
- Misses       3161     3168       +7
Impacted Files Coverage Δ
src/config.h 100.00% <ø> (ø)
src/fork_gc.c 57.08% <0.00%> (-0.84%) ⬇️
src/indexer.c 92.54% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb8cd4...a6191a1. Read the comment docs.

@ashtul ashtul mentioned this pull request Jun 8, 2020
Closed
MeirShpilraien
MeirShpilraien reviewed Jun 8, 2020
View reviewed changes
src/pytest/test.py Outdated
@@ -3003,6 +3003,7 @@ def testIssue1184(env):

field_types = ['TEXT', 'NUMERIC', 'TAG']
for ft in field_types:
env.assertOk(env.execute_command('ft.config', 'set', 'FORK_GC_CLEAN_THRESHOLD', 0))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not setting it once before the loop?

MeirShpilraien
MeirShpilraien reviewed Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment.

@ashtul ashtul merged commit 58f8eff into master Jun 8, 2020
@ashtul ashtul deleted the Change-forkGC-threshold-to-100 branch June 8, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeirShpilraien MeirShpilraien MeirShpilraien approved these changes

@rafie rafie Awaiting requested review from rafie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the default FORK_GC_CLEAN_THRESHOLD=100
2 participants
@ashtul @MeirShpilraien