Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-1313] fix fieldmask for phonetics #1330

Merged
merged 1 commit into from
Jul 13, 2020
Merged

[Issue-1313] fix fieldmask for phonetics #1330

merged 1 commit into from
Jul 13, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jul 13, 2020

fix #1313
changes in spec.c are where FieldSpec used sp instead of fs.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1330 into master will not change coverage.
The diff coverage is 96.15%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1330   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         144      144           
  Lines       19847    19847           
=======================================
  Hits        14681    14681           
  Misses       5166     5166           
Impacted Files Coverage Δ
src/spec.c 82.84% <95.83%> (ø)
src/ext/default.c 88.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e449fda...78601aa. Read the comment docs.

@ashtul ashtul merged commit 13b6daa into master Jul 13, 2020
@ashtul ashtul deleted the Issue1313 branch July 13, 2020 12:16
ashtul added a commit that referenced this pull request Jul 13, 2020
ashtul added a commit that referenced this pull request Jul 13, 2020
* fix fieldmask for phonetics (#1330)

* remove ON HASH
ashtul added a commit that referenced this pull request Jul 13, 2020
* fix fieldmask for phonetics (#1330)

* remove ON HASH
ashtul added a commit that referenced this pull request Jul 14, 2020
* fix fieldmask for phonetics (#1330)

* remove ON HASH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected: "field does not support phonetics"
2 participants