Reimplemented background indexing indication #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
+ Coverage 80.65% 80.66% +0.01%
==========================================
Files 143 143
Lines 19952 19957 +5
==========================================
+ Hits 16092 16099 +7
+ Misses 3860 3858 -2
Continue to review full report at Codecov.
|
|
The corresponding Coordinator PR: RediSearch/RSCoordinator#145 |
ashtul
reviewed
Aug 10, 2020
There was a problem hiding this comment.
@rafie I added two small comments, other then this looks good.
MeirShpilraien
approved these changes
Aug 10, 2020
ashtul
added a commit
that referenced
this pull request
Aug 11, 2020
* replace w/o reindex * WIP * Add TODO comment * handle SET/Rename * hsetnx/hincrby/hincrbyfloat * fix leak * return ASAP * rename for different index * fix leak * fix aof test * restore/dump tests added * comment * Reimplemented background indexing indication (#1403) * replace w/o reindex * WIP * Add TODO comment * handle SET/Rename * hsetnx/hincrby/hincrbyfloat * fix leak * return ASAP * rename for different index * fix leak * fix aof test * restore/dump tests added * comment * small fix for rebase * use switch * format * add config flag * fix test Co-authored-by: Rafi Einstein <rafi@redislabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.