Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alias name beginning with AS #3259

Merged
merged 3 commits into from Dec 1, 2022
Merged

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Nov 30, 2022

Allow alias name to begin with AS instead of failing

127.0.0.1:6379> FT.CREATE idx SCHEMA a TEXT 

127.0.0.1:6379> FT.SEARCH idx * RETURN 3 a AS asa
(error) Alias for RETURN cannot be `AS`

127.0.0.1:6379> FT.AGGREGATE idx * LOAD 3 a AS asa
(error) Alias for RETURN cannot be `AS`

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 82.98% // Head: 82.98% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (89132be) compared to base (3f95dcb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   82.98%   82.98%   -0.01%     
==========================================
  Files         181      181              
  Lines       30171    30171              
==========================================
- Hits        25038    25037       -1     
- Misses       5133     5134       +1     
Impacted Files Coverage Δ
src/aggregate/aggregate_request.c 96.42% <100.00%> (ø)
src/spec.c 87.92% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oshadmi oshadmi marked this pull request as ready for review November 30, 2022 21:12
@oshadmi oshadmi merged commit 092b55b into master Dec 1, 2022
@oshadmi oshadmi deleted the omer_allow_alias_begin_with_as branch December 1, 2022 17:25
oshadmi added a commit that referenced this pull request Dec 2, 2022
* Allow alias name beginning with AS

* Add test

(cherry picked from commit 092b55b)
rafie pushed a commit that referenced this pull request Dec 27, 2022
* Allow alias name beginning with AS

* Add test

(cherry picked from commit 092b55b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants