fixed case issue MOD-4872 #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafie
previously approved these changes
Feb 20, 2023
rafie
previously approved these changes
Feb 20, 2023
Codecov ReportBase: 82.72% // Head: 82.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3403 +/- ##
==========================================
- Coverage 82.72% 82.65% -0.07%
==========================================
Files 175 175
Lines 29921 29940 +19
==========================================
- Hits 24752 24748 -4
- Misses 5169 5192 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
oshadmi
reviewed
Feb 21, 2023
| @@ -213,7 +213,7 @@ QueryNode *NewPrefixNode_WithParams(QueryParseCtx *q, QueryToken *qt, bool prefi | |||
| ret->pfx.suffix = suffix; | |||
| q->numTokens++; | |||
| if (qt->type == QT_TERM) { | |||
| char *s = rm_strdupcase(qt->s, qt->len); | |||
| char *s = rm_strndup_unescape(qt->s, qt->len); | |||
There was a problem hiding this comment.
Need to also handle PARAMS, such as this test
(QT_TERM_CASE and QT_PARAM_TERM_CASE ?)
oshadmi
reviewed
Feb 23, 2023
| n->children = array_ensure_append(n->children, children + ii, 1, QueryNode *); | ||
| for(size_t jj = 0; jj < QueryNode_NumParams(child); ++jj) { | ||
| Param *p = child->params + jj; | ||
| p->type = PARAM_TERM_CASE; |
There was a problem hiding this comment.
When evaluating PARAM_TERM_CASE we use rm_strdup and not rm_strndup_unescape
Line 176 in 7eae2f6
So we do not unescape params?
oshadmi
previously approved these changes
Feb 26, 2023
oshadmi
approved these changes
Feb 27, 2023
rafie
pushed a commit
that referenced
this pull request
Feb 28, 2023
* fixed case issue * rename function + fix test * param bigfix + test * Add waitForIndex in test:testGroupByWithApplyError * Fix for test_short_read failure * test_short_read fix 2 --------- Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> Co-authored-by: rafie <rafi@redislabs.com> (cherry picked from commit a21efd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redunant "to lower" transformation for prefix nodes and introduces
rm_strndupescapeto duplicate and escape strings.The prefix string will be modify to lower case when in
query_EvalSingleTagNodecalls totag_strtolowerwhen tag field is case sensitiveQuery_EvalPrefixNodecallsstrToFoldedRuneswhich transform the query string into lower case regardlessadded test
closes MOD-4872, closes #3391