Report indexing failures on ft.info - MOD-5364 #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvirDukhan
force-pushed
the
dvirdu_index_failure_report
branch
from
2c73600
to
74d9095
Compare
alonre24
previously approved these changes
Dec 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alonre24
approved these changes
Dec 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
GuyAv46
added a commit
that referenced
this pull request
Dec 26, 2023
* scaffolding * per field info + vector test * numeric * cosmetics * wip * wip * added exception message for hash and JSON failures * wip * wip * pytest pass for index error * wip * tests pass + coordinator pass * removed warnings * free resources * clear field spec info * added const to reply * free resources * cast to remove const * sanitizer build warning fix * remove print * free resources * clear query errors * post merge fixes * minor fixes * more fixes * import fix * some tests changes * fix incorrect offset * remove unneeded helpers * move field stats to the end of the info list * added a test * align code * fix for cluster * simple review fixes * added timestamps for indexing * added timespec to the struct * improved test * extend mock API * review fixes * fix alignment * fix misalignment --------- Co-authored-by: GuyAv46 <guy.avimor@gmail.com> Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Report indexing failures on ft.info - MOD-5364 (#3682) * scaffolding * per field info + vector test * numeric * cosmetics * wip * wip * added exception message for hash and JSON failures * wip * wip * pytest pass for index error * wip * tests pass + coordinator pass * removed warnings * free resources * clear field spec info * added const to reply * free resources * cast to remove const * sanitizer build warning fix * remove print * free resources * clear query errors * post merge fixes * minor fixes * more fixes * import fix * some tests changes * fix incorrect offset * remove unneeded helpers * move field stats to the end of the info list * added a test * align code * fix for cluster * simple review fixes * added timestamps for indexing * added timespec to the struct * improved test * extend mock API * review fixes * fix alignment * fix misalignment --------- Co-authored-by: GuyAv46 <guy.avimor@gmail.com> Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> * revert numeric types in ft.info * revert tests info types * fix index error tests for old info types * test fixes for coordinator --------- Co-authored-by: DvirDukhan <dvir@redis.com>
raz-mon
pushed a commit
that referenced
this pull request
Mar 6, 2024
* scaffolding * per field info + vector test * numeric * cosmetics * wip * wip * added exception message for hash and JSON failures * wip * wip * pytest pass for index error * wip * tests pass + coordinator pass * removed warnings * free resources * clear field spec info * added const to reply * free resources * cast to remove const * sanitizer build warning fix * remove print * free resources * clear query errors * post merge fixes * minor fixes * more fixes * import fix * some tests changes * fix incorrect offset * remove unneeded helpers * move field stats to the end of the info list * added a test * align code * fix for cluster * simple review fixes * added timestamps for indexing * added timespec to the struct * improved test * extend mock API * review fixes * fix alignment * fix misalignment --------- Co-authored-by: GuyAv46 <guy.avimor@gmail.com> Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds index failures reporting on the
FT.INFOcommand.This PR introduces two new objects that hold statistics to be used in the info command
Those objects implement the following new traits:
Reply- The object is responsible for sending the suitable replyDeserialize- Reconstruct an object fromMRReply- valid for cluster operations onlyOpPlusEquals(operator +=) - The object can append/merge additional objects to itself - valid for cluster operation only where aggregations are required.Implementing those traits makes those objects usable in info command code paths both for single shard and cluster.
Usage:
hash_indexing_failuresentry. This allows registering more general errors, not necessarily related to a specific field.This PR also introduces more verbose error reporting for hash and JSON indexing failures, both field-related (pre-process) and document related.
TODO: