Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2544: replace VSS tutorial and move orig. content #3760

Merged
merged 3 commits into from Aug 31, 2023

Conversation

dwdougherty
Copy link
Collaborator

Describe the changes in the pull request

There is a requirement to replace the current vector similarity search content, Search and query > Search > Vector similarity, with content more tutorial in nature. This PR replaces the existing content with tutorial-style content written by Brian Sam-Bodden. The current content is being moved to Search and query > Advanced concepts > Vectors

Which issues this PR fixes

  1. DOC-2544

Main objects this PR modified

  1. docs/docs/search/vectors.md

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@dwdougherty
Copy link
Collaborator Author

dwdougherty commented Aug 11, 2023

This merge can't happen until my code example is merged into redis-py. See redis/redis-py#2886 .

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.59% ⚠️

Comparison is base (8ee53da) 82.80% compared to head (d94adfa) 82.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3760      +/-   ##
==========================================
- Coverage   82.80%   82.21%   -0.59%     
==========================================
  Files         192      191       -1     
  Lines       32540    32410     -130     
==========================================
- Hits        26944    26647     -297     
- Misses       5596     5763     +167     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwdougherty
Copy link
Collaborator Author

The code example has been merged, so this PR can now be merged as well. @adrianoamaral: would you please merge this?

@dmaier-redislabs dmaier-redislabs merged commit 8c14679 into RediSearch:master Aug 31, 2023
10 checks passed
@dwdougherty dwdougherty deleted the doc-2544 branch August 31, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants