fix 2.8 crash, and enable load after filter #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
commented
Aug 31, 2023
| @@ -250,6 +250,53 @@ def testFilter(self): | |||
| self.env.assertLess(int(row['count']), 5) | |||
| self.env.assertGreater(int(row['count']), 2) | |||
|
|
|||
| def testFilterBeforeLoad(self): | |||
There was a problem hiding this comment.
Previously, this caused a crash
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3808 +/- ##
==========================================
+ Coverage 82.75% 82.80% +0.04%
==========================================
Files 192 192
Lines 32540 32544 +4
==========================================
+ Hits 26930 26948 +18
+ Misses 5610 5596 -14
☔ View full report in Codecov by Sentry. |
DvirDukhan
approved these changes
Aug 31, 2023
GuyAv46
added a commit
that referenced
this pull request
Sep 1, 2023
* fix 2.8 crash, and enable load after filter * added a test * revert temporary test lines
2 tasks
GuyAv46
added a commit
that referenced
this pull request
Sep 1, 2023
* fix 2.8 crash, and enable load after filter * added a test * revert temporary test lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR is an alternative fix for #3809 and #3790. It is keeping the behavior of keeping
FILTERsteps in the coordinator but enables other steps that come after aFILTERstep to move to the shards, if possible.This fixes a bug that caused a
LOADstep after aFILTERstep to stay in the coordinator plan and later caused a crash on 2.8.Which issues this PR fixes
Mark if applicable