[2.6] MOD-5768: Fix tls on Redis 7.2 oss cluster #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
On Redis 7.2 (specifically on 7.2-rc3) there was a change made that allow running on cluster with both, tls and none tls port. As part of this change, `cluster slot` command will return the port base of the connection type (tls or not tls). A side effect of this change is that when `cluster slot` called using `RM_Call` it is always gets the none tls port (which break our support of tls). To fix this, use `RedisModule_GetClusterNodeInfo` Redis module API to get the correct port. Notice that this is a minimal fix, we should extend the Redis module API to provide us with all the information we need (including slot range) so we will not have to use `cluster slot` command at all. (cherry picked from commit 59c6636)
(cherry picked from commit 911f0c6)
(cherry picked from commit 642db33)
2 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #3899 +/- ##
==========================================
- Coverage 82.52% 82.52% -0.01%
==========================================
Files 176 176
Lines 30123 30124 +1
==========================================
Hits 24859 24859
- Misses 5264 5265 +1
☔ View full report in Codecov by Sentry. |
DvirDukhan
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3837 to
2.6.