New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOD-5211: Propagate errors from shards to coordinator #3938
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3938 +/- ##
==========================================
- Coverage 82.82% 82.80% -0.02%
==========================================
Files 192 192
Lines 32650 32658 +8
==========================================
+ Hits 27041 27043 +2
- Misses 5609 5615 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Few comments
Successfully created backport PR for |
Backport failed for Please cherry-pick the changes locally. git fetch origin 2.10
git worktree add -d .worktree/backport-3938-to-2.10 origin/2.10
cd .worktree/backport-3938-to-2.10
git checkout -b backport-3938-to-2.10
ancref=$(git merge-base b7bdc96723d862060dee771602f99e22c82b8043 2c60b5fa53745073730165379fcb71a7f254fbc9)
git cherry-pick -x $ancref..2c60b5fa53745073730165379fcb71a7f254fbc9 |
Backport failed for Please cherry-pick the changes locally. git fetch origin 2.6
git worktree add -d .worktree/backport-3938-to-2.6 origin/2.6
cd .worktree/backport-3938-to-2.6
git checkout -b backport-3938-to-2.6
ancref=$(git merge-base b7bdc96723d862060dee771602f99e22c82b8043 2c60b5fa53745073730165379fcb71a7f254fbc9)
git cherry-pick -x $ancref..2c60b5fa53745073730165379fcb71a7f254fbc9 |
Currently, the coordinator neglects errors it gets from the shards. This PR fixes this behavior, such that the coordinator will report to the user any error the shards send it.
Mark if applicable