MOD-6232 Incorrect initialization of numeric range maximum value #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change range.maxVal WIP
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4147 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 191 191
Lines 32592 32593 +1
=======================================
+ Hits 27180 27182 +2
+ Misses 5412 5411 -1 ☔ View full report in Codecov by Sentry. |
fix range maxval to be -inf
meiravgri
changed the title
meiravgri
commented
Dec 4, 2023
meiravgri
commented
Dec 4, 2023
alonre24
reviewed
Dec 4, 2023
alonre24
approved these changes
Dec 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
This was referenced Dec 7, 2023
|
Successfully created backport PR for |
ephraimfeldblum
pushed a commit
that referenced
this pull request
Dec 17, 2023
* add test WIP change range.maxVal WIP * fix negative values test * skip test on coordinator * add ft.profile test fix range maxval to be -inf * little fix * Update tests/pytests/test_profile.py --------- Co-authored-by: alonre24 <alonreshef24@gmail.com>
raz-mon
pushed a commit
that referenced
this pull request
Mar 6, 2024
* add test WIP change range.maxVal WIP * fix negative values test * skip test on coordinator * add ft.profile test fix range maxval to be -inf * little fix * Update tests/pytests/test_profile.py --------- Co-authored-by: alonre24 <alonreshef24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the pull request
MOD-6232 Fix: Range Maximum Value Initialization
Previously, the maximum value of the range was initialized as the smallest positive double. Consequently, the limit of nodes containing only negative values is never updated to its actual, smaller value. This oversight adversely impacted search performance.
For more detailed insights into its impact, refer to:
https://redislabs.atlassian.net/wiki/spaces/DX/pages/4057825319/BUG+Incorrect+Initialization+of+Numeric+Range+Maximum+Value
This PR fixes the issue by initializing the range maximum value to
-inf, Additionally, it introduces a new test intest_profile.pyvalidating this fix.Additional Test for Bug Fix in PR Fix uniquesum and cardinalities values corruption after gc - MOD-5815 #3892 this PR includes a test addressing a bug previously fixed in PR #3892 - Fix uniquesum and cardinalities values corruption after gc. The added test is designed to replicate the problem identified in https://redislabs.atlassian.net/browse/MOD-6076
Which issues this PR fixes
Mark if applicable