MOD-5990: Return timeout error from cursor on strict timeout policy #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
- Coverage 83.37% 83.36% -0.02%
==========================================
Files 191 191
Lines 32592 32590 -2
==========================================
- Hits 27173 27168 -5
- Misses 5419 5422 +3 ☔ View full report in Codecov by Sentry. |
raz-mon
changed the title
raz-mon
force-pushed
the
razmon-return_error_from_cursors
branch
from
e4755ce
to
562d572
Compare
oshadmi
reviewed
Dec 4, 2023
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
ephraimfeldblum
pushed a commit
that referenced
this pull request
Dec 17, 2023
…4149) * return errors from cursor * Update test comment Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * fix test name * fix comment --------- Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
raz-mon
added a commit
that referenced
this pull request
Mar 6, 2024
…4149) * return errors from cursor * Update test comment Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * fix test name * fix comment --------- Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we return the number of aggregated results and the results aggregated until experiencing a timeout on a cursor command, no matter the timeout policy. This PR fixes this behavior to return a timeout error (accompanied with a
0cursor id, as before) when the timeout policy is strict (i.e.,ON_TIMEOUT FAIL).This PR also enables to return other errors from a cursor, which is a behavior we do not currently exploit. This situation is rare also for non-cursor commands, yet we want to have unified behaviors for the cursor in this regard.
(Related to #4059)
Mark if applicable