MOD-6002: Fixes for FT.PROFILE's time reporting
#4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4264 +/- ##
==========================================
+ Coverage 83.81% 84.35% +0.53%
==========================================
Files 192 192
Lines 33791 33460 -331
==========================================
- Hits 28323 28225 -98
+ Misses 5468 5235 -233 ☔ View full report in Codecov by Sentry. |
oshadmi
previously approved these changes
Dec 26, 2023
oshadmi
previously approved these changes
Dec 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
oshadmi
previously approved these changes
Dec 27, 2023
oshadmi
previously approved these changes
Dec 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
raz-mon
force-pushed
the
razmon-fix_profile
branch
from
1b2b3e1
to
8bef3cb
Compare
oshadmi
previously approved these changes
Jan 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
oshadmi
approved these changes
Jan 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-4264-to-2.8 origin/2.8
cd .worktree/backport-4264-to-2.8
git switch --create backport-4264-to-2.8
git cherry-pick -x ea69686de07ee8fac53b8b253f4e570e6e458b22 6f5f24be9f51be3059363049dcc6c18d15dd18a5 8bef3cb191281aab05714dcdd097080ea6ddd6f5 bc58460d77d449db3dffd9843355525e93b6402e 4c9e20e527e5fcfee12be943c13452d35dd51588 e7ef2c6d2be7d2a01b6ef9cec030a35e8840300c b2b1462d335482d387a338fc036b08118b534e28 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-4264-to-2.6 origin/2.6
cd .worktree/backport-4264-to-2.6
git switch --create backport-4264-to-2.6
git cherry-pick -x ea69686de07ee8fac53b8b253f4e570e6e458b22 6f5f24be9f51be3059363049dcc6c18d15dd18a5 8bef3cb191281aab05714dcdd097080ea6ddd6f5 bc58460d77d449db3dffd9843355525e93b6402e 4c9e20e527e5fcfee12be943c13452d35dd51588 e7ef2c6d2be7d2a01b6ef9cec030a35e8840300c b2b1462d335482d387a338fc036b08118b534e28 |
raz-mon
added a commit
that referenced
this pull request
Jan 7, 2024
* revert transition to hires clock * fix * fix flaky test * Add test * Skip on sanitizer, reduce number of docs * Test coordinator timer, remove duplicate code * Add docs to test (remove flakiness)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2024
* revert transition to hires clock * fix * fix flaky test * Add test * Skip on sanitizer, reduce number of docs * Test coordinator timer, remove duplicate code * Add docs to test (remove flakiness)
raz-mon
added a commit
that referenced
this pull request
Mar 6, 2024
* revert transition to hires clock * fix * fix flaky test * Add test * Skip on sanitizer, reduce number of docs * Test coordinator timer, remove duplicate code * Add docs to test (remove flakiness)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our
FT.PROFILEresponse is populated with many0's, due to bad casting which cuts off the accumulated time per result in the aggregation pipeline. This PR reverts the changes introduced in #2989, back to working with theclockfunction (which is still in use in other parts of the project).If we wish to support higher clock resolution later on, we should use the
struct timespecthat supports nano-second resolution rather than the clock's micro-seconds.Mark if applicable