[2.8] [MOD-6022] fix flakyness of test_expire:testExpireDocs #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
we skip this test for Redis versions below 7.2 due to a bug in PEXPIRE. In older versions, a bug involving multiple time samplings during PEXPIRE execution can cause keys to prematurely expire, triggering a "del" notification and eliminating them from the index, thus missing from search results. This impacts the test as the key should be included in the search results but return NULL upon access (i.e lazy expiration). The bug was resolved in Redis 7.2, ensuring the test's stability. (cherry picked from commit 3afdc42)
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #4275 +/- ##
==========================================
+ Coverage 83.42% 83.45% +0.02%
==========================================
Files 193 193
Lines 33989 33989
==========================================
+ Hits 28356 28365 +9
+ Misses 5633 5624 -9 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Dec 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4271 to
2.8.