MOD-6597: Fix numeric index deletion #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4513 +/- ##
==========================================
+ Coverage 85.43% 85.46% +0.03%
==========================================
Files 188 188
Lines 32892 32892
==========================================
+ Hits 28101 28111 +10
+ Misses 4791 4781 -10 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Mar 13, 2024
|
Successfully created backport PR for |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-4513-to-2.6 origin/2.6
cd .worktree/backport-4513-to-2.6
git switch --create backport-4513-to-2.6
git cherry-pick -x 6e3bc74d48e3b56284e053c4e6670555d03dba9d 3925390ccd7625d3ce137d7f1048c7d922c0175c 87b3c1c184258f671d871b5a0eb64815b1136247 |
|
Successfully created backport PR for |
raz-mon
added a commit
that referenced
this pull request
Mar 19, 2024
* Fix numeric index deletion bug * Remove periodic runs of the GC in test * Enhance test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
We have a bug in our numeric index - we don't update the
revisionIdwhen we trim the Tree (inNumericRangeTree_TrimEmptyLeaves), causing us not to abort the reading of the numeric index for an invalidated cursor upon opening an invalidatedNumericRangeIterator, and possibly crash.Mark if applicable