Groupby recursion cleanup - [MOD-7245] #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
==========================================
+ Coverage 85.68% 86.21% +0.53%
==========================================
Files 188 190 +2
Lines 33064 35042 +1978
==========================================
+ Hits 28331 30213 +1882
- Misses 4733 4829 +96 ☔ View full report in Codecov by Sentry. |
GuyAv46
changed the title
DvirDukhan
approved these changes
Jun 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
* cleanup recursion * added a test * remove unreachable code (cherry picked from commit 295e141)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
* cleanup recursion * added a test * remove unreachable code (cherry picked from commit 295e141)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
* cleanup recursion * added a test * remove unreachable code (cherry picked from commit 295e141)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Cleanup for the group extraction recursion, so it easier to follow whats going on
Mark if applicable