[2.8] MOD-5977 MOD-5866: Fix inverted index memory counting (#4218) #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> (cherry picked from commit 959ed1a)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #4669 +/- ##
==========================================
+ Coverage 84.23% 84.30% +0.07%
==========================================
Files 193 193
Lines 34112 34126 +14
==========================================
+ Hits 28735 28771 +36
+ Misses 5377 5355 -22 ☔ View full report in Codecov by Sentry. |
oshadmi
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4218 to
2.8.(cherry picked from commit 959ed1a)
Which issues this PR fixes
(done through MOD-6515)
Some of the fields returned by
FT.INFOin2.8are strings but the same fields in master are returned as integers. Thus, some tests needed to include the type conversion.