Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended metric collection and saving on DB loaders #26

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Extended metric collection and saving on DB loaders #26

merged 4 commits into from
Apr 3, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Mar 26, 2020 •
edited
Loading

fixes #24 , #25 and #27

@codecov
Copy link

codecov bot commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #26 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   34.74%   34.74%           
=======================================
  Files           2        2           
  Lines         118      118           
=======================================
  Hits           41       41           
  Misses         76       76           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a835c...a7b91c9. Read the comment docs.

@filipecosta90 filipecosta90 added the enhancement New feature or request label Apr 3, 2020
@filipecosta90 filipecosta90 self-assigned this Apr 3, 2020
@filipecosta90 filipecosta90 added this to Done in 0.3.0 Apr 3, 2020
@filipecosta90 filipecosta90 moved this from Done to In progress in 0.3.0 Apr 3, 2020
@filipecosta90 filipecosta90 changed the title [wip] working on extended metric collection and saving on loader Extended metric collection and saving on DB loaders Apr 3, 2020
@filipecosta90 filipecosta90 merged commit 0f84b6c into master Apr 3, 2020
@filipecosta90 filipecosta90 linked an issue Apr 3, 2020 that may be closed by this pull request
provide normalized json output exporter for loaders #25
Closed
@filipecosta90 filipecosta90 deleted the loader.metrics branch May 20, 2020 11:40
@filipecosta90 filipecosta90 moved this from In progress to Done in 0.3.0 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@filipecosta90 filipecosta90

Labels
enhancement New feature or request
Projects
0.3.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide normalized json output exporter for loaders provide indexing rate info also in BW metrics (MB/s)
1 participant
@filipecosta90