Add serialization of data types #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnunberg
reviewed
Mar 3, 2019
mnunberg
reviewed
Mar 4, 2019
|
@mnunberg Finally all tests check, both with AOF and RDB I still haven't switched to |
lantiga
changed the title
|
I had to temporarily disable AOF as I stumbled on something that needs further investigation: AOF loading seem to choke on commands that use |
|
Confirmed: https://github.com/antirez/redis/blob/unstable/src/aof.c#L808 |
|
@mnunberg This is an issue for later, we should review/merge as is and open a separate issue. |
This was referenced Mar 5, 2019
This was referenced Mar 5, 2019
Closed
lantiga
added a commit
that referenced
this pull request
May 6, 2020
Add serialization of data types (#72) * Add serialization of data types * Add AofRewrite (it might go in the future) and replication * Saving/loading tensors to/from RDB now working * Fix loading scripts * Handle encver properly * Use zero initialization for the error struct * Fix for script serialization. Add tests. * Fix length of input and output arrays * Fix arguments to calloc * Use getkeys-api * Use array_new instead of plain array * Disable AOF for now * Improve testing of unhappy paths * More unhappy path tests * Temporarily stop when AOF if activated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #64.
In a nutshell:
NOTE this is WIP, not ready for review yet (needs testing).