String tensor support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the data is given by VALUE (and not with BLOB)
for setting and getting string tensors by VALUE
from numpy string array as blob
to test tensorset with numpy string array
GuyAv46
force-pushed
the
string_tensor_support
branch
from
d7d8cb7
to
fd3627b
Compare
Added a comment. Deleted numpy_string2blob and replaced with a single line using join. Deleted utils.recursive_bytetransform_str and sets 'target' to a decode function
alonre24
approved these changes
Dec 1, 2021
| @@ -38,7 +43,9 @@ def blob2numpy( | |||
| """Convert `BLOB` result from RedisAI to `np.ndarray`.""" | |||
| mm = {"FLOAT": "float32", "DOUBLE": "float64"} | |||
| dtype = mm.get(dtype, dtype.lower()) | |||
| if mutable: | |||
| if dtype == 'string': | |||
| a = np.array(value.decode().split('\0')[:-1], dtype='str') | |||
There was a problem hiding this comment.
You take [:-1] because the last item is the empty string after the last \0in the blob right? Consider documenting it
|
Kudos, SonarCloud Quality Gate passed!
|
DvirDukhan
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, added only support for STRING tensors set with VALUE.