-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trimmed mean and symetric trimmed mean implementations and tests #22
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 84.98% 86.71% +1.73%
==========================================
Files 1 1
Lines 253 286 +33
==========================================
+ Hits 215 248 +33
Misses 38 38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great.
Quick minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #16 .
This PR adds the following 2 new APIs:
td_trimmed_mean
: Returns the trimmed mean ignoring values outside given cutoff upper and lower limitstd_trimmed_mean_symmetric
: Returns the trimmed mean ignoring values outside given a symmetric cutoff limitsTo test out I've used scipy's stats
trim_mean
To get a grasp of the trimmed means performance I've added a set of benchmarks. Here are the full benchmark results: