Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-precision overflow detection on h->unmerged_weight #26

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

filipecosta90
Copy link
Collaborator

No description provided.

@filipecosta90 filipecosta90 added the enhancement New feature or request label Sep 11, 2022
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #26 (143b0d9) into master (049c2b2) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   87.93%   88.08%   +0.15%     
==========================================
  Files           1        1              
  Lines         315      319       +4     
==========================================
+ Hits          277      281       +4     
  Misses         38       38              
Impacted Files Coverage Δ
src/tdigest.c 88.08% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipecosta90
Copy link
Collaborator Author

thank you for the fast review @ashtul !

@filipecosta90 filipecosta90 merged commit b8c65dc into master Sep 11, 2022
@filipecosta90 filipecosta90 deleted the add.overflow branch September 11, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants