Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When pausing a stream based registration, the current batch is processed but its records remain in the stream #761

Closed
spicy-sauce opened this issue Apr 26, 2022 · 0 comments · Fixed by #763
Closed

When pausing a stream based registration, the current batch is processed but its records remain in the stream #761

spicy-sauce opened this issue Apr 26, 2022 · 0 comments · Fixed by #763

Comments

@spicy-sauce
Copy link

No description provided.

MeirShpilraien added a commit that referenced this issue Apr 28, 2022
@MeirShpilraien
Fix #761, Fix #760, stream reader fixes to Pause and Unregister
0180bd9 
1. Fix stream reader pause to ack after finish processing the current batch.
2. Fix stream reader unregister to stop processing more batches when finished the current batch.
@MeirShpilraien MeirShpilraien mentioned this issue Apr 28, 2022
Merged
MeirShpilraien added a commit that referenced this issue May 1, 2022
@MeirShpilraien
Fix #761, Fix #760, stream reader fixes to Pause and Unregister (#763)
5ab60c6 
* Fix #761, Fix #760, stream reader fixes to Pause and Unregister

1. Fix stream reader pause to ack after finish processing the current batch.
2. Fix stream reader unregister to stop processing more batches when finished the current batch.

* fix fluky tests

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #761, Fix #760, stream reader fixes to Pause and Unregister RedisGears/RedisGears
1 participant
@spicy-sauce