centos8 #636
Merged
centos8 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d5f9715)
rafie
reviewed
Nov 17, 2021
Comment on lines
33
to
+34
| RUN ./deps/readies/bin/getpy2 | ||
| RUN test -f /usr/bin/python || ln -s /usr/bin/python2 /usr/bin/python |
There was a problem hiding this comment.
Also possible: FIX=1 ./deps/readies/bin/getpy2
There was a problem hiding this comment.
We're not merging this back to master. It's a cut-throat patch. Didn't know, thanks - will use next time!
rafie
reviewed
Nov 17, 2021
| @@ -117,7 +117,9 @@ OBJECTS=$(patsubst $(SRCDIR)/%.c,$(BINDIR)/%.o,$(SOURCES)) | |||
| CC_DEPS = $(patsubst $(SRCDIR)/%.c, $(BINDIR)/%.d, $(SOURCES)) | |||
|
|
|||
| CC_FLAGS += \ | |||
| -fPIC -std=gnu99 \ | |||
| -fPIC \ | |||
| -fcommon \ | |||
There was a problem hiding this comment.
IMO this is more risky than my change, but I'll go with it.
There was a problem hiding this comment.
@rafie can you explain why? What risks do you see with it?
(cherry picked from commit 883918f)
MeirShpilraien
approved these changes
Nov 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.