adding tests for scalar arrys

RedisGrafana · Jun 13, 2023 · 8886c47 · 8886c47
1 parent 23a3efd
commit 8886c47
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/pkg/redis-json.go b/pkg/redis-json.go
@@ -139,7 +139,7 @@ func queryJsonGet(qm queryModel, client redisClient) backend.DataResponse {
 					case float64:
 						fields[i] = data.NewField(i, nil, []float64{})
 						for j := 0; j < rowscount-1; j++ {
-							fields[i].Append(0)
+							fields[i].Append(float64(0))
 						}
 					}
 					frame.Fields = append(frame.Fields, fields[i])

diff --git a/pkg/redis-json_test.go b/pkg/redis-json_test.go
@@ -160,6 +160,55 @@ func TestQueryJsonObjKeys(t *testing.T) {
 func TestQueryJsonGet(t *testing.T) {
 	t.Parallel()
 
+	t.Run("Should return four strings in frame", func(t *testing.T) {
+		t.Parallel()
+
+		client := testClient{rcv: "[[],\"gin\",\"rum\",\"whiskey\"]"}
+
+		resp := queryJsonGet(queryModel{Command: models.JsonGet, Key: "test:json", Path: "$.num"}, &client)
+
+		require.Len(t, resp.Frames, 1)
+		require.Len(t, resp.Frames[0].Fields, 1)
+		require.Equal(t, resp.Frames[0].Fields[0].Len(), 4)
+		require.Equal(t, resp.Frames[0].Fields[0].At(0), "")
+		require.Equal(t, resp.Frames[0].Fields[0].At(1), "gin")
+		require.Equal(t, resp.Frames[0].Fields[0].At(2), "rum")
+		require.Equal(t, resp.Frames[0].Fields[0].At(3), "whiskey")
+	})
+
+	t.Run("Should return four booleans in frame", func(t *testing.T) {
+		t.Parallel()
+
+		client := testClient{rcv: "[[],true,false,true]"}
+
+		resp := queryJsonGet(queryModel{Command: models.JsonGet, Key: "test:json", Path: "$.num"}, &client)
+
+		require.Len(t, resp.Frames, 1)
+		require.Len(t, resp.Frames[0].Fields, 1)
+		require.Equal(t, resp.Frames[0].Fields[0].Len(), 4)
+		require.Equal(t, resp.Frames[0].Fields[0].At(0), false)
+		require.Equal(t, resp.Frames[0].Fields[0].At(1), true)
+		require.Equal(t, resp.Frames[0].Fields[0].At(2), false)
+		require.Equal(t, resp.Frames[0].Fields[0].At(3), true)
+	})
+
+	t.Run("Should return four float64 in frame", func(t *testing.T) {
+		t.Parallel()
+
+		client := testClient{rcv: "[[],42,43,44]"}
+
+		resp := queryJsonGet(queryModel{Command: models.JsonGet, Key: "test:json", Path: "$.num"}, &client)
+
+		require.Len(t, resp.Frames, 1)
+		require.Len(t, resp.Frames[0].Fields, 1)
+		require.Equal(t, resp.Frames[0].Fields[0].Len(), 4)
+		require.Equal(t, resp.Frames[0].Fields[0].At(0), float64(0))
+		require.Equal(t, resp.Frames[0].Fields[0].At(1), float64(42))
+		require.Equal(t, resp.Frames[0].Fields[0].At(2), float64(43))
+		require.Equal(t, resp.Frames[0].Fields[0].At(3), float64(44))
+
+	})
+
 	t.Run("Should return a single float64 in frame", func(t *testing.T) {
 		t.Parallel()