-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATCH (n) RETURN n throws AssertionError #2930
Comments
I suspect this is a Jedis issue, not RedisGraph. @sazzad16 can you please check if these queries are handled correctly?
|
@LiorKogan Jedis does not check BTW, Java, even the latest Java, has no separate definition for negative NaN. So, what should Jedis do when it is a |
There is no notion of a "negative NaN" in IEEE-754 arithmetic. RedisGraph currently returns a nonstandard "-nan" string instead of "nan". @AviAvni @swilly22 Why do we do this? Can we fix it in 2.12? @sazzad16 all RedisGraph versions out there return such nonstandard string. Can we add a manual check? |
@LiorKogan We can check. But, again, what can we do when it is found to be a |
@sazzad16 We should treat |
I don't see any special code in RedisGraph to print "-nan", it is the text returned by |
Due to usages of `sprintf(str, "%.15g", d);` when d is NaN. From @LiorKogan: "We should treat `-nan` as `nan`". References: - RedisGraph/RedisGraph#2930
Due to usages of `sprintf(str, "%.15g", d);` when d is NaN. From @LiorKogan: "We should treat `-nan` as `nan`". References: - RedisGraph/RedisGraph#2930
Due to usages of `sprintf(str, "%.15g", d);` when d is NaN. From @LiorKogan: "We should treat `-nan` as `nan`". References: - RedisGraph/RedisGraph#2930
Since Jedis 4.4.0 (redis/jedis#3329), it accepts |
We discovered a bug that MATCH (n) RETURN n throws AssertionError.
I first randomly create a graph. Then when I run the following query:
MATCH (n) RETURN n
is thrown without further message to identify the root cause. I think this query is definitely correct, but I keep triggering this kind of problem.In the stack trace, I also cannot identify what kinds of problem of this. Is this caused related to my created graph data?
Expected behavior:
No exception should be expected to throw.
Actual behavior:
A
java.lang.AssertionError
is thrown. And I'm not really sure whether this problem should happen so I report this.Steps to reproduce:
We feel sorry that because the database schema and data values are randomly generated by strings, it will cause inconvenience to your reviewing, but we believe the problem does exist.
Following the following graph data generation query, we can reproduce the bugs:
The text was updated successfully, but these errors were encountered: